Add filesystem_loader with spec

percy / percy-capybara

Visual testing for Capybara with Percy.

https://docs.percy.io/docs/capybara

MIT License

45 stars 23 forks source link

Add filesystem_loader with spec #19

Closed timhaines closed 7 years ago

timhaines commented 7 years ago

Todos:

[x] Set loader options in client initialize
[x] Rename asset_path to assets_dir
[x] Check asset_path is absolute
[x] Add option for base_url
[ ] Discuss not making initialize_loader and loader_options private
[x] Add warning when NativeLoader being used as the fallback.

timhaines commented 7 years ago

@fotinakis ha! I'm totally going to plug in rubocop this afternoon to take care of all of those minor syntax things for us.

fotinakis commented 7 years ago

👍 LGTM! 🎉

Potential optional updates per discussion: test for the default where base_url is not given, and tests for when assets_dir ends or doesn't end with a slash.