native_loader.rb: Adding :asset_hostnames option

percy / percy-capybara

Visual testing for Capybara with Percy.

https://docs.percy.io/docs/capybara

MIT License

45 stars 23 forks source link

native_loader.rb: Adding :asset_hostnames option #23

Closed guilherme closed 7 years ago

guilherme commented 7 years ago

In some cases assets are served from 3rd party servers that are on private networks and Percy can't reach them. This option will enable to send to percy the assets that come from these servers.

timhaines commented 7 years ago

Thanks so much for this @guilherme! I've pulled your PR and made a couple of tweaks. Mostly around relaxing our (new, still in the process of tuning) Rubocop rules, and some small style adjustments.

Can you take a look over at https://github.com/percy/percy-capybara/pull/24 - and once you're happy with that, I'll merge it and we'll get a new release shipped.

Thanks again for the contribution here!