search

percy / percy-capybara

Visual testing for Capybara with Percy.
https://docs.percy.io/docs/capybara
MIT License
45 stars 23 forks source link

Warning being seen from Faraday due to unexpected middleware #45

Closed rsimha closed 7 years ago

rsimha commented 7 years ago

This started recently, presumably due to faraday receiving a version bump.

WARNING: Unexpected middleware set after the adapter. This won't be supported from Faraday 1.0.

See https://github.com/percy/percy-capybara/blob/68a6dc2257dad18d1237c3c9772c1ee073e206d0/percy-capybara.gemspec#L31

rsimha commented 7 years ago

Here's an example of the warning we're seeing. Note that all our logs are silenced, and the only ones being printed are by Percy.

https://travis-ci.org/ampproject/amphtml/jobs/257300515#L649

rsimha commented 7 years ago

/cc @fotinakis @timhaines

timhaines commented 7 years ago

This logging really comes from our percy-client gem. The logging is resolved if we switch the order of these two lines.

However, that breaks this test which I haven't been able to figure out just now. We'll work on this @rsimha-amp.

timhaines commented 7 years ago

@rsimha-amp This should be resolved now with the release of percy-client 1.13.5. If you update your gem bundle and still see issues with this, please let me know.

rsimha commented 7 years ago

Cool, will do. Thanks!

rsimha commented 7 years ago

I just checked our logs, and the errors are gone. Thanks for the fix.