search

percy / percy-capybara

Visual testing for Capybara with Percy.
https://docs.percy.io/docs/capybara
MIT License
45 stars 23 forks source link

Update to token only build creation endpoint #55

Closed maprules1000 closed 6 years ago

maprules1000 commented 6 years ago

Removes checks for PERCY_PROJECT to enable support for the new token only build creation endpoint.

Note: this will be updated with the new percy-client gem before it is shipped. https://github.com/percy/percy-client/pull/39

joscha commented 6 years ago

for people still being on older clients, PERCY_TOKEN is still needed? I think some documentation about why the PERCY_TOKEN was removed and in which version it is not needed any more would be great. I found this pull request after being confused about why the settings page of a project doesn't show the project any more. We still have a few older clients out there (storybook and capybara) which would need updating first before we can leave out the project. I used <organization>/<slug> in the meantime for new projects with old clients and hope that will work? //cc @timhaines

references https://github.com/percy/percy-storybook/pull/44

maprules1000 commented 6 years ago

Hey @joscha! Older clients still do need both PERCY_TOKEN and PERCY_PROJECT. The most recent version of percy-capybara removed the need for the PERCY_PROJECT env variable. New projects that use the project variable will still work without a hitch since the percy client will just not look for it, but the token variable is still required.

I've updated the release notes for this library to specifically call out the removal of PERCY_PROJECT as well. https://github.com/percy/percy-capybara/releases/tag/v3.2.0

I hope that clears everything up!

joscha commented 6 years ago

@maprules1000 is the way to get to the project I described above correct?