search

percy / percy-cli-ruby

[Deprecated] Command-line interface for Percy.
https://percy.io/docs/clients/ruby/cli
MIT License
19 stars 11 forks source link

pass in ignore_regex option to ignore files from taking a snapshot #15

Closed bostonaholic closed 6 years ago

bostonaholic commented 6 years ago

This adds the ability to pass in the --ignore_regex option to ignore certain files from taking a snapshot.

My use case: I have a static site that is using JavaScript on a page to randomize some seed data. I'd prefer to just skip snapshots on this page entirely.

timhaines commented 6 years ago

Thanks @bostonaholic! We'll take a look at this asap.

Ignore the linting failures in CI - they're caused by our central styles being updated very recently, and this repo not being updated yet to stay inline with them. I'll fix that.

bostonaholic commented 6 years ago

@timhaines feel free to push any changes you see fit!

bostonaholic commented 6 years ago

Weird that I ran rubocop -a and it made changes to use path.match? but then the travis build for ruby 2.1 and 2.2 failed due to undefined method 'match?' for #<String:0x0000000439c318>. I'll install ruby 2.1 and rerun rubocop.

timhaines commented 6 years ago

@bostonaholic We'll want this library to continue to support Ruby 2.1 and 2.2. I think we need to update our shared rubocop rules to not insist on Ruby 2.4.

bostonaholic commented 6 years ago

@timhaines I made the changes but it's still failing on Travis. Maybe the rubocop.yml rules need updated? It's failing in the ruby 2.1 and 2.2 builds with the same undefined method 'match?' for #<String:0x0000000439c318> error, even though ruby 2.1 and 2.2 don't have String#match.

timhaines commented 6 years ago

I think we're likely to drop Ruby 2.1 from the travis config too, seeing as it's unsupported now.

faun commented 6 years ago

This has been merged. If you rebase off percy:master, I believe this PR will be marked as merged. Once I close this PR, you will no longer be able to push to it, marking it as closed.

faun commented 6 years ago

I'm going to close this issue, since all commits have been merged to master.