search

percy / percy-cli-ruby

[Deprecated] Command-line interface for Percy.
https://percy.io/docs/clients/ruby/cli
MIT License
19 stars 11 forks source link

ignore_regex option fix #16

Closed maprules1000 closed 6 years ago

maprules1000 commented 6 years ago

This fixes the broken ignore_regex option and cleans up the snapshot_runner a bit.

timhaines commented 6 years ago

@maprules1000 I think it may be worth updating the .rubocop file to specify ruby version 2.2 as well, and dropping the ruby 2.1 tests from Travis - just to get CI green again.

timhaines commented 6 years ago

@maprules1000 I pushed a commit which fixes CI - I wanted to tackle that in case it got hairy (it didn't).

As part of that I ran rubocop corrections locally, and it forced a few other small changes, including the removal of that rogue line 44.

I'll leave it to you to review the other comments, merge, and ship as you see fit.