Don't die if out of plan

percy / percy-cypress

Visual testing with Cypress and Percy

https://percy.io

MIT License

346 stars 40 forks source link

Don't die if out of plan #14

Closed mitar closed 5 years ago

mitar commented 5 years ago

It seems currently Percy integration dies if you run of your plan limits. I would propose that CI should still run, but a warning should be issued, similar to #3.

Robdel12 commented 5 years ago

Hey @mitar!

I believe this was fixed with this commit upstream: https://github.com/percy/percy-agent/commit/7e92365023f8869377ae4d9eb71f04c929941144

Using the latest version of the SDK, do you sill see this happening?

mitar commented 5 years ago

Currently I am not our of plan, so cannot test this. :-) But great to see this was fixed. I suggest we close the issue then.

Robdel12 commented 5 years ago

Okay cool, if the issue does come up we’ll reopen and get it squashed for you!