search

percy / percy-ember

Ember addon for visual regression testing with Percy
https://docs.percy.io/docs/ember
MIT License
73 stars 44 forks source link

window.Testem.afterTests is causing a global failure #12

Closed stevenwanderski closed 8 years ago

stevenwanderski commented 8 years ago

The following line: https://github.com/percy/ember-percy/blob/master/addon/finalize.js#L18 is causing a global failure in the Ember test suite:

Uncaught TypeError: Cannot read property 'afterTests' of undefined

image

My stats: Ember 2.4.6 Ember Data 2.7.0

fotinakis commented 8 years ago

Hmm, it seems that window.Testem is not defined for you? Which is very odd, looking around for why this might be.

fotinakis commented 8 years ago

Figured it out, it's QUnit specific and only happens when you're visiting /tests directly, not in ember test mode.

Fixing here: https://github.com/percy/ember-percy/pull/13 and then will release a new version.

fotinakis commented 8 years ago

Deployed in v1.2.3, thanks for the report.

amk221 commented 5 years ago

Does this mean percy tests can't be run from the browser?