search

percy / percy-ember

Ember addon for visual regression testing with Percy
https://docs.percy.io/docs/ember
MIT License
73 stars 44 forks source link

ember-component-css compatiblity #21

Closed fotinakis closed 4 years ago

fotinakis commented 7 years ago

For users using ember-component-css, integration tests apparently don't include the component styles, so the snapshot that Percy captures does not contain styles. This is not a Percy bug, but maybe there is a way we can make this easier / or documented?

Apparently the fix is needing import 'dummy/initializers/component-styles'; in integration tests.

If anyone has an example addon/app that uses ember-component-css and is using Percy, would love to work with you to get this officially supported.

RobbieTheWagner commented 5 years ago

@fotinakis any updates on this?

Robdel12 commented 4 years ago

This shouldn't be an issue in v2 (with asset discovery rather than using the ember build system). Feel free to comment back if that's not the case 👍