search

percy / percy-ember

Ember addon for visual regression testing with Percy
https://docs.percy.io/docs/ember
MIT License
73 stars 44 forks source link

remove @percy/agent as a dependency #243

Closed chrisvdp closed 3 years ago

chrisvdp commented 4 years ago

Problem

@percy/agent is quite a large download. Chromium itself is 130.3 Mb. This download is incurred by everyone who installs ember-percy, even though, in our case at least, the Percy agent is only ever invoked in ci. We would prefer to install the Percy agent either globally at each ci run, or as part of our docker container.

Solution

Require users of ember-percy to also either add @percy/agent to their package.json or install it globally.

Note

This may also be a use case for peer dependencies, but it seems that this package does not require specific versions of the Percy agent.

wwilsman commented 4 years ago

Hey @chrisvdp!

We actually plan on making this change to all of our SDKs in the next major release (along with other changes such as not automatically downloading Chromium on install). No exact timeline yet, but definitely soon!

We'll leave this issue open until then for others asking the same. 👍

chrisvdp commented 4 years ago

Great to hear. Thanks.

ctjhoa commented 3 years ago

@wwilsman Can you confirm this is solved with @percy/ember@3.0.0 (#272) and percy-cli config https://docs.percy.io/docs/skipping-asset-discovery-browser-download ?

Robdel12 commented 3 years ago

Hey @ctjhoa! That's correct -- I'll go ahead and close this issue out too 💯