search

percy / percy-ember

Ember addon for visual regression testing with Percy
https://docs.percy.io/docs/ember
MIT License
73 stars 44 forks source link

Type definition missing option #249

Closed mfeckie closed 3 years ago

mfeckie commented 4 years ago

https://github.com/percy/ember-percy/blob/master/types/index.d.ts#L5-L11

percyCSS?: string is missing from the available options

mfeckie commented 4 years ago

Would you folks be happy with a PR?

Secondly, would you folks be interested in having the addon converted to TypeScript so that types would be automatically kept in sync?

Robdel12 commented 4 years ago

Hey @mfeckie! A PR would be great for the type update. We'll pass on converting to TS :)