search

percy / percy-ember

Ember addon for visual regression testing with Percy
https://docs.percy.io/docs/ember
MIT License
73 stars 44 forks source link

Fastboot support #3

Closed mike-north closed 6 years ago

mike-north commented 8 years ago

Looks like we're starting two percy builds and finishing once, due to recent changes in the way an ember "fastboot build" is created

# was
ember fastboot:build
# is now
ember build

Guards:

// node land
EMBER_CLI_FASTBOOT === 'true' // in fastboot mode
// browser land
typeof FastBoot === 'undefined' // not in fastboot mode
fotinakis commented 8 years ago

Thanks @mike-north for this and for the chat!

For reference, I cannot reproduce the fastboot double-build behavior we were seeing at all. Here is an ember-percy test run, with ember-cli-fastboot 1.0.0-beta.4, without the process.env. EMBER_CLI_FASTBOOT check we added, and everything works fine:

https://travis-ci.org/percy/ember-percy/jobs/145164369

fotinakis commented 6 years ago

Closing stale issue.