search

percy / percy-ember

Ember addon for visual regression testing with Percy
https://docs.percy.io/docs/ember
MIT License
73 stars 44 forks source link

percySnapshot is not defined #38

Closed kellyselden closed 7 years ago

kellyselden commented 7 years ago

I started getting this issue on CI this morning. No percy related changes.

https://travis-ci.org/kellyselden/package-hint-historic-resolver/jobs/264821527#L2740

timhaines commented 7 years ago

Hi @kellyselden. Did you upgrade ember-exam or anything else in the testing pipeline? We haven't made a change recently that would obviously lead to this.

kellyselden commented 7 years ago

I haven't. What happened was, greenkeeper gave me a PR for ember-cli-content-security-policy bumping to 1.0.0. Tests pass. Merged, then the failure. I haven't added new code to the project in forever, so what most likely happened is the npm cache got invalidated, and some dep is causing this now.

kellyselden commented 7 years ago

hmmm I have a hunch it is ember-cli-babel 6.8.0, which was just released...

timhaines commented 7 years ago

@kellyselden Thanks Kelly, it'd be great to hear if that's the cause. Otherwise, we're happy to help troubleshoot.

kellyselden commented 7 years ago

Here's the issue https://github.com/babel/ember-cli-babel/issues/178

I'm pretty sure it's related.

rwjblue commented 7 years ago

https://github.com/ember-cli/babel-plugin-ember-modules-api-polyfill/pull/19 is the root cause

rwjblue commented 7 years ago

basically import './helpers/percy-snapshot' is being removed, making the test helper undefined 😢

rwjblue commented 7 years ago

ember-cli-babel@6.8.1 has been published, which should fix this

timhaines commented 7 years ago

Thanks @rwjblue. @kellyselden, I'm closing this issue. But please do feel welcome to re-open or resubmit if there's anything we can assist with.