search

percy / percy-ember

Ember addon for visual regression testing with Percy
https://docs.percy.io/docs/ember
MIT License
73 stars 44 forks source link

Shadow DOM support for Ember #705

Closed itsjwala closed 1 year ago

itsjwala commented 1 year ago

Discussed in https://github.com/percy/percy-ember/discussions/704

Originally posted by **c69-addepar** January 25, 2023 Hi Team, @itsjwala , since `1.19.0-alpha.0`, `@percy/cli` now supports Shadow DOM. Unfortunately, the changes in that repo alone are not enough to enable support for Ember apps. See https://github.com/percy/cli/pull/1165#issuecomment-1403956686 Happy to provide more details if needed. CC: @mmun @aschenoni
c69-addepar commented 1 year ago

Thank you so much @itsjwala ! We have confirmed that @percy/cli 1.19.2 + @percy/ember 4.0.2 work well with our code.

This allowed us to remove the fork of 1.0.3, and switch back to mainline Percy! 🎉