fix: Give PercyScript its own user agent

percy / percy-script

[Deprecated] PercyScript is the easiest way to get started with visual testing and Percy.

https://percy.io

MIT License

2 stars 2 forks source link

fix: Give PercyScript its own user agent #8

Closed Robdel12 closed 5 years ago

Robdel12 commented 5 years ago

What is this?

We're finally going to be able to spot when someone is using PercyScript (rather than it always showing as the Puppeteer SDK).

This does duplicate most of the puppeteer SDK, but that's okay. Every other SDK uses the same exact pattern for extracting the DOM from the test browser and then POST'ing that back to the agent process. I don't think we're actually DRYing anything up.

TODO:

[ ] Patch or minor? fix: vs feat:

wwilsman commented 5 years ago

RE: fix vs. feat, I'd consider this a bug if it didn't report properly. So probably fix even though we're changing deps and internal logic, the public API stays the same with the addition of the client info.