search

percy / percy-selenium-java

Visual testing with Java Selenium and Percy
https://docs.percy.io/docs/java-selenium
MIT License
12 stars 17 forks source link

Propose to fix some problems #43

Closed KengoTODA closed 5 years ago

KengoTODA commented 5 years ago

Thanks for sharing your interesting products! I wanna suggest several changes here:

  1. Fix placeholder of JUL logger. Current log message contains {} unexpectedly, see https://github.com/percy/percy-java-selenium/issues/42#issue-509130684 for example.
  2. Fix leaked resources by the try-with-resources.
KengoTODA commented 5 years ago

Use #45 instead.