search

percy / percy-selenium-java

Visual testing with Java Selenium and Percy
https://docs.percy.io/docs/java-selenium
MIT License
12 stars 17 forks source link

fix: Resource leak problems with HttpClient & InputStream (rebased) #45

Closed KengoTODA closed 5 years ago

KengoTODA commented 5 years ago
  1. Fix resource leak by using try-with-resources for HttpClient
  2. Fix resource leak by using try-with-resources for InputStream
  3. Stop packaging percy-agent.js into the built artifact (.jar file)

I think 3 is necessary because #44 makes this module loading percy-agent.js from the server. This change makes pom.xml enough simple.

Robdel12 commented 5 years ago

Great stuff @KengoTODA, thank you for the PR 😃

KengoTODA commented 5 years ago

Confirmed that newly released artifact works in my project. Thank you!