percy / percy-selenium-js

Selenium.js client library for visual regression testing with Percy
MIT License
2 stars 2 forks source link

Wrong type definition in 2.0.2 #429

Closed thorsten-wolf-neptune closed 9 months ago

thorsten-wolf-neptune commented 10 months ago

The problem

When using Percy in Typescript it is currently not working as the typedefinitions don't reflect that there is a percyScreenshot function exported. It only tells there is a default percySnapshot which is not aligning with the actual index.js file: https://github.com/percy/percy-selenium-js/blob/151b286df58a420d060049422b5d43aecfabefbf/types/index.d.ts#L4C39-L4C39

Environment

Details

If necessary, describe the problem you have been experiencing in more detail.

Debug logs

If you are reporting a bug, always include logs! Give the "Debugging SDKs" document a quick read for how to gather logs

Please do not trim or edit these logs, often times there are hints in the full logs that help debug what is going on.

Code to reproduce issue

Use Percy in typescript. My workaround is to use @ts-ignore and then it works. image

github-actions[bot] commented 9 months ago

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] commented 9 months ago

This issue was closed because it has been stalled for 28 days with no activity.