percy / percy-storybook

Percy's Storybook SDK.
https://docs.percy.io/docs/storybook
MIT License
150 stars 45 forks source link

Test / allow regular expressions as story parameters (include/exclude) #313

Closed wwilsman closed 3 years ago

wwilsman commented 3 years ago

The code is written to accept regex-like strings, which is a vestige from the previous versions of this SDK. We should allow real regular expressions to be accepted as well.

For story parameters, we can stringify the regex when fetching stories (if it isn't already).

This might be interesting for the Percy config file options since it's validated using JSON. In which, real regular expressions aren't allowed. So how can we allow real regular expressions in JS config files?

wwilsman commented 3 years ago

Addressed during #354