search

percy / percy-xcui-swift

XCUI Swift SDK for App Percy
MIT License
0 stars 2 forks source link

Allow configuring a different hostname than “percy.cli” #10

Closed sampettersson closed 8 months ago

sampettersson commented 1 year ago

In environments where access to /etc/hosts isn't permitted (like Xcode Cloud) having the hostname for the CLI hard-coded makes it quite hard to use this library at the moment.

So to remedy that I added an argument to the initialiser for the AppPercy class allowing customisation of the hostname, if nil is sent (which is the default argument value) the default hostname "percy.cli" will be used like before, making this a non breaking change for the library consumer.

prklm10 commented 8 months ago

Thanks @sampettersson for raising this PR. Sorry for a late response. We have added your changes in https://github.com/percy/percy-xcui-swift/pull/14

prklm10 commented 8 months ago

This is done. So we are closing this PR.