search

percy / percy-xcui-swift

XCUI Swift SDK for App Percy
MIT License
0 stars 2 forks source link

Latest code does not compile #12

Closed pjcook closed 6 months ago

pjcook commented 7 months ago

The latest lint fix commit breaks the SDK. Instead of removing the override keyword, you should have swapped

override public func viewDidLoad() {

for

public override func viewDidLoad() {

Screenshot 2024-02-29 at 16 18 35
ruixhuang commented 7 months ago

+1

pjcook commented 7 months ago

I created this fork and committed the above change along with fixing all the code and syntax issues in the unit tests. I couldn't actually figure out how to run the tests successfully, but at least they compile now. https://github.com/pjcook/percy-xcui-swift

prklm10 commented 6 months ago

Hi all, Sorry for late response. We have fixed this issue in #14. This should not be a problem now.

prklm10 commented 6 months ago

We are closing this issue.