test: check for py36 support

percy / python-percy-client

[Deprecated] Python client library for visual regression testing with Percy.

https://percy.io/docs/clients/python/selenium

MIT License

21 stars 24 forks source link

test: check for py36 support #101

Closed joshuarli closed 4 years ago

joshuarli commented 4 years ago

I'm aware this is a deprecated client, so you (maintainers) can ignore this. Just testing to see if it passes your test suite on 2.7, 3.6 because we (Sentry) intend on using the deprecated client if it turns out to just work on 3.6.

joshuarli commented 4 years ago

Huh, unsure why you have cryptography pinned to a really old version in requirements_dev.

I'm guessing it's pinned for pyOpenSSL which requests will pull in for a security extra, but that isn't the case anymore IIRC?

Anyways, it doesn't seem to be used, not even transiently. Also ref: https://github.com/percy/python-percy-client/pull/88

So just gonna remove to unblock CI.

joshuarli commented 4 years ago

Sweet, it works.