percy / storybook-action

[Deprecated] A GitHub action to run Percy with Storybook
https://docs.percy.io/docs/github-actions#section-storybook-action
MIT License
11 stars 5 forks source link

'percy-storybook@latest' is not in the npm registry. #6

Closed squidsoup closed 4 years ago

squidsoup commented 4 years ago

When running percy/storybook-action@v0.1.3

/usr/local/bin/npx percy-storybook
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/percy-storybook - Not found
npm ERR! 404 
npm ERR! 404  'percy-storybook@latest' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2020-03-10T06_04_09_392Z-debug.log
Install for [ 'percy-storybook@latest' ] failed with code 1

From what I can gather this should be @percy/storybook rather than percy-storybook?

Robdel12 commented 4 years ago

Hey @squidsoup, thanks for the report! This shouldn't fail if you have @percy/storybook installed as a dependency in the project. percy-storybook is the executables name, which should be found if installed.

squidsoup commented 4 years ago

Hey @squidsoup, thanks for the report! This shouldn't fail if you have @percy/storybook installed as a dependency in the project. percy-storybook is the executables name, which should be found if installed.

Oh apologies, that makes sense. Perhaps an update to the storybook-action docs to make it clear that dependency is required? I see that this is mentioned here, but my first thought was to start with the github action to setup the integration.

Robdel12 commented 4 years ago

@squidsoup Gotcha! We try to highlight at the top of the docs that CI setup should come after the SDK is setup:

image