search

percyhanna / rquery

A testing utility that provides React tree traversal similar to jQuery
MIT License
56 stars 9 forks source link

Add .html() method, and support for extensions #13

Closed percyhanna closed 9 years ago

percyhanna commented 9 years ago

Addresses #12.

percyhanna commented 9 years ago

@scruffles I would love to hear some feedback from you on this implementation.

scruffles commented 9 years ago

Looks great. I meant to submit a pull request but got sidetracked on another project.

I'm not a huge fan of using the term 'mixin' this way.. I always think of a mixin as an OO concept for cross cutting concerns. This seems to be more of an extension mechanism, like a plugin. I can see wanting consistency with backbone though.

Thanks for adding this.

percyhanna commented 9 years ago

You and I both share the same opinion on the term mixin, but I did choose it to be consistent with Underscore's mixin and extend method. I would prefer extend I think, so I think I'll switch that up.