search

perennialAutodidact / memory-snap

0 stars 0 forks source link

52 gameboard style adjustments #59

Closed russfraze closed 1 year ago

russfraze commented 1 year ago

## Description of changes I copied the styles you showed, and made a slight adjustment so the photos don't stretch. I also adjusted some of the sizes in the TileGrid component. I think this looks good now.

Test steps

Look at images in full screen on this branch.

russfraze commented 1 year ago

I feel like this one doesn't need additional tests. Let me know if that checks out.

russfraze commented 1 year ago

@perennialAutodidact Just made that change.

Just a side note: the images are different then before which means that not all images on pexels have a square format. Just something to keep in mind in case we need a greater variety if images at some point.

perennialAutodidact commented 1 year ago

@perennialAutodidact Just made that change.

Just a side note: the images are different then before which means that not all images on pexels have a square format. Just something to keep in mind in case we need a greater variety if images at some point.

I think I'm okay with that. I'd rather have images that fit well within the tile than have to mess with styling images that aren't the right size. If it becomes a problem down the road, we can always make the switch. I chose Pexels in part because they offer square images from their API. The user will have the option to decide what kind of images they want on their tiles as part of the setup form, so the images will vary from game to game anyway.