perennialAutodidact / memory-snap

0 stars 0 forks source link

check for match before changing current player #89

Closed russfraze closed 8 months ago

russfraze commented 8 months ago

## Description of changes Now in the handle flipped pair reducer action, we check for a match before changing the current player. If its a match, the current player stays the same, if not, the current player advances.

Test steps

Play the game and check that the current player stays the same after a match is made.

russfraze commented 8 months ago

@perennialAutodidact check this out. Not the current player stays the same and you can show your kid whos boss by dominating the game.

perennialAutodidact commented 8 months ago

Nice work on this bug. Everything works as expected on my end. I think the tests will be more concise if we move them, as mentioned in my other comment.

perennialAutodidact commented 8 months ago

Actually, I've discovered a bug.

russfraze commented 8 months ago

@perennialAutodidact Great job catching that bug. Its fixed and the tests have been changed. Check out this PR when you get a second. Should be good to go!