search

pereorga / minimalist-web-notepad

Minimalist Web Notepad
https://notes.orga.cat
1.01k stars 276 forks source link

Support setting $base_url automatically #39

Closed josark2005 closed 4 years ago

josark2005 commented 4 years ago

Set $base_url automatically, and it can be set by the environment variable.

josark2005 commented 4 years ago

If you accept this pull request, remember to modify README.md. :>

pereorga commented 4 years ago

Hi,

Thank you for the pull request. I'm not sure, but for the sake of simplicity, I may want keep the existing code.

darkdragon-001 commented 4 years ago

I was thinking about this myself, but actually setting $base_url to an empty string results in absolute paths being used which works with every base URL. So this is only needed when a path with a prefix is used.