search

perezdev / CMVModBot

A moderation bot for /r/ChangeMyView to automate rule violations.
7 stars 0 forks source link

Rule E - Ignore top level comments that have been removed by a mod #13

Open Snorrrlax opened 6 years ago

Snorrrlax commented 6 years ago

A rule violation shouldn't count towards the Rule E removal conditions, like one did here: https://www.reddit.com/r/changemyview/comments/7y5evw/cmv_about_the_parkland_school_shooting_and_arming/

Edit: Just realised in the case above, the Rule 1 removal occurred after the Rule E removal, which means the bot didn't do anything wrong. But the question still stands: will the bot check for removals if they are made first?

perezdev commented 6 years ago

But the question still stands: will the bot check for removals if they are made first?

The bot will act on the post if the post has not been removed. So if a mod records the rule violation and makes a comment, but doesn't remove the post, then it will still act. But I think in most cases the post will be removed, right? I can add in additional logic to not act if another rule violation has been made in SnooNotes besides Rule 2, but we'd be coding around a rare exception, I think.

Snorrrlax commented 6 years ago

Sorry - I'm referring to top level comments being removed, not the post itself. So if OP only receives three comments, but all three are removed for Rule 1 (i.e. blatant agreement with the view), does the bot remove the post for no OP replies?

perezdev commented 6 years ago

Ah. It probably will still count those, as the I'm 99% sure the bot doesn't check if a comment has been removed. But I'll fix that.