perezjln / gym-lowcostrobot

Other
21 stars 5 forks source link

Update readme training script args and requirements #28

Closed lil-km closed 3 months ago

lil-km commented 3 months ago

The command pip install rl_zoo3 is not included in the requirements.

Running the training command resulted in an error: rl_zoo3_conf.yaml could not be found because it is located in the examples folder.

When running the gym-lowcostrobot training command, I received an error: unexpected keyword argument 'observation_mode'. This issue arises from the observation_mode keyword argument in the rl_zoo3_conf.yaml file for the ReachCube-V0 environment.

The argument -orga does not exist in the train script of rl_zoo3.

perezjln commented 3 months ago

Hello @qgallouedec, would you mind having a look, for the orga please. I suppose it is --orga assuming the correct version of zoo. @lil-km - Regarding rl_zoo3_conf.yaml , we should maybe put the example/ dir as prefix to prevent confusion.

qgallouedec commented 3 months ago

Thanks @lil-km!

The command pip install rl_zoo3 is not included in the requirements

It's because it's not required for installing this package. rl_zoo3 is only required if you want to train one env with it. You can add pip install rl_zoo3 before the training command though.

I suppose it is --orga assuming the correct version of zoo.

No, orga is for pushing to hub (rl_zoo3.push_to_hub)

So appart from installation instruction, lgtm

perezjln commented 3 months ago

Thanks @qgallouedec ,

No, orga is for pushing to hub (rl_zoo3.push_to_hub)

So it means one should add this extra command into the readme maybe.

qgallouedec commented 3 months ago

Make sure to place the rl-zoo3 installation command in the right section (I can see it hasn't been corrected in this pr)