search

perf101 / rage

Results And Graphing Engine
Other
8 stars 8 forks source link

Add an option for a new zoomable graph #76

Closed thisisALPINE closed 7 years ago

thisisALPINE commented 7 years ago

Originally rage had a static graph based on the Flot library. This pull request adds a new zoomable dynamic graph based on the D3 library.

A new switch besides the draw button lets you choose between the Flot and the D3 graph.

thisisALPINE commented 7 years ago

Updated as requested.

jjd27 commented 7 years ago

Those changes are great; thanks. Would you be able to squash the new commits into the original ones, please? Then we won't have one commit adding 7000 lines and another commit removing them.

thisisALPINE commented 7 years ago

Squashed as requested.

jjd27 commented 7 years ago

I can still see https://github.com/perf101/rage/pull/76/commits/24da74d74a2282e08377e08052d7df0b14d61b60 as a separate commit. I think it should be squashed into https://github.com/perf101/rage/pull/76/commits/834bd68c1ce9735e01094052ca94cad1a647abff. Also that commit should contain https://github.com/perf101/rage/pull/76/commits/cc62471d5882efdc444e7624310141c525b89008 which would not work in isolation due to not having a change_graph() function.

thisisALPINE commented 7 years ago

Squashed.

thisisALPINE commented 7 years ago

Squashed c4170bd into 748d7c1.

jjd27 commented 7 years ago

Merged; thanks @thisisALPINE!