perfanalytics / pose2sim

Markerless kinematics with any cameras — From 2D Pose estimation to 3D OpenSim motion
https://perfanalytics.github.io/pose2sim/
BSD 3-Clause "New" or "Revised" License
271 stars 50 forks source link

Progress on the integration of sports2D & Real-time #139

Closed AurelienCoppee closed 1 week ago

AurelienCoppee commented 1 month ago

Complementary branch of the one on sports2D

davidpagnon commented 1 month ago

It seems like the checks are failing, here is the error message:

./Pose2Sim/poseEstimation.py:203:52: F821 undefined name 'prev_keypoints'
            keypoints, scores, multi_person, None, prev_keypoints, pose_tracker
                                                   ^
./Pose2Sim/poseEstimation.py:237:111: F821 undefined name 'fps'
            fps = finalize_video_processing(frames_processed, total_processing_start_time, output_video_path, fps)
                                                                                                              ^
./Pose2Sim/poseEstimation.py:3[16](https://github.com/perfanalytics/pose2sim/actions/runs/11533136985/job/32110315178?pr=139#step:8:17):56: F821 undefined name 'prev_keypoints'
                keypoints, scores, multi_person, None, prev_keypoints, pose_tracker
                                                       ^
3     F821 undefined name 'prev_keypoints'
davidpagnon commented 1 month ago

I don't have time to look into it, but it might be due to the sorting algorithm, which is not exactly identical between sports2d and pose2sim. I had planned to make them use the same function but did not find time for it

AurelienCoppee commented 1 month ago

I made them use the same function but forgot to initialize some variables 😬

davidpagnon commented 3 weeks ago

Hi, same error as last time :) I'm not sure why I have to approve before checks are run while I don't need it within Sports2D, but I'll try to do it faster the next time!