perfanalytics / pose2sim

Markerless kinematics with any cameras — From 2D Pose estimation to 3D OpenSim motion
https://perfanalytics.github.io/pose2sim/
BSD 3-Clause "New" or "Revised" License
271 stars 50 forks source link

Why the name of the camera in intrinsic calibration is set to cam_01 instead of the true name of the video ? #51

Closed ANaaim closed 1 year ago

ANaaim commented 1 year ago

Hello,

In calibration.py the function calibrateintrinsics ''change the name of the camera'' : C.append(f'cam{str(i+1).zfill(2)}')

Should not it be like in the conversion files (example in qualysis) where the name of the camera is the name of the camera in the folder ? I need these information later on and having the camera in the calibration file having the same name as in the ''real camera'' would be easy.

Best regard,

davidpagnon commented 1 year ago

I don't see any reason for it, so if you feel like proposing the change, feel absolutely free to do so! 😊

ANaaim commented 1 year ago

Great, I will do the PR ==> for me would be more logical to have the name of the cam to be sure to associate the information to the correct camera.