perfanalytics / pose2sim

Markerless kinematics with any cameras — From 2D Pose estimation to 3D OpenSim motion
https://perfanalytics.github.io/pose2sim/
BSD 3-Clause "New" or "Revised" License
271 stars 50 forks source link

Latest release is broken? #60

Closed JohannesTimter closed 10 months ago

JohannesTimter commented 10 months ago

I just pulled the repository and upgraded Pose2Sim to the latest version 0.5.3. Unfortunately this new version isn't working for me. When trying to do the tutorial (Demonstration Part-1) i get the following error: WithLimbSwapping

I thought i may be because of the recently added limb swapping, but when I disable it in config.toml I just get another error: WithoutLimbSwapping

I get the same behavior with data that has previously worked. I will just work with an older version until this is fixed.

davidpagnon commented 10 months ago

Sorry yes, it is broken due to the last push I did this afternoon in order to better handle lens distortions, I should have used the draft branch but I got confused. I'll fix it in the evening!

JohannesTimter commented 10 months ago

Nice, thank you. The new folder structure looks good, I want to use it.

davidpagnon commented 10 months ago

Hi there, it should be fixed but please leave the parameter undistort_points to false in Config.toml, I still have a few issues when handling distortions.

JohannesTimter commented 10 months ago

Haven't tested it but I trust you