Closed judicaelclair closed 3 years ago
Merging #22 (8856a0e) into master (8b7767b) will increase coverage by
3.17%
. The diff coverage is91.66%
.
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 79.67% 82.85% +3.17%
==========================================
Files 45 48 +3
Lines 2047 2222 +175
==========================================
+ Hits 1631 1841 +210
+ Misses 416 381 -35
Impacted Files | Coverage Δ | |
---|---|---|
src/structures/tracked_container.py | 88.23% <ø> (+29.41%) |
:arrow_up: |
src/structures/tracked_heap.py | 85.71% <ø> (+38.09%) |
:arrow_up: |
src/structures/tracked_list.py | 92.30% <ø> (+42.30%) |
:arrow_up: |
src/simulator/services/services.py | 50.90% <33.33%> (-0.47%) |
:arrow_down: |
...ator/services/event_manager/events/reinit_event.py | 75.00% <75.00%> (ø) |
|
src/structures/tracked_set.py | 83.82% <77.14%> (+35.04%) |
:arrow_up: |
...st_configuration/test_tracked/test_tracked_heap.py | 96.66% <96.66%> (ø) |
|
...st_configuration/test_tracked/test_tracked_list.py | 97.61% <97.61%> (ø) |
|
...est_configuration/test_tracked/test_tracked_set.py | 98.66% <98.66%> (ø) |
|
... and 8 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8b7767b...8856a0e. Read the comment docs.
seems strange that tracked container doesn't keep track of the added and removed elements separately, but if it works for you...
We could in the future track both, but it doesn't help for the current optimisations.
Rady:
TrackedSet
implemented.Tracked
structures.Judi:
SimulatorConfig
state withSimulatorConfigState
and ability to dump arbitrary objects to json.ReinitEvent
and changed the meaning ofResetEvent
to just mean resetting the current algorithm, not a full re-initialisation.