perfectly-balanced / PathBench

Benchmarking Platform for Classic and Learned Path Planning Algorithms.
Other
92 stars 18 forks source link

Point class v2.0 #5

Closed Nabushika closed 3 years ago

Nabushika commented 3 years ago

Made point class use a position tuple, so can use 2, 3, or more dimensions. Should be a drop in replacement for the old point.

Changes

Future possible things to do/questions to reviewers

Things to review

judicaelclair commented 3 years ago
Nabushika commented 3 years ago
  • Definitely need to homogenise __repr__ - same style regardless of the dimension (a future todo).
  • test_ne_pos only checks for changes in y-coordinate, but changes in x / z aren't tested.

Both should be fixed in the latest commit -- __repr__ style is now consistent and reflected in tests.