Enhancements to Data Preprocessing and Popup HTML Generation, fixing spaghetti code - Githubissues

perfectly-preserved-pie / larentals

An interactive map of for-sale & rental property listings in Los Angeles County, updated weekly.

https://wheretolive.la

20 stars 4 forks source link

Enhancements to Data Preprocessing and Popup HTML Generation, fixing spaghetti code #150

Closed perfectly-preserved-pie closed 1 year ago

perfectly-preserved-pie commented 1 year ago

Split out functions from the dataframe files into their own function file. Refactor each function to use type hints and docstrings (nice!)

Data Preprocessing

Rows with missing mls_number, street_number, and street_name are now dropped to clean the dataset.
Added a new column full_street_address by combining existing columns to facilitate better mapping.
Postal codes are converted to Int64 dtype.
Replaced NaN values in specified columns with 'N/A'. Unknown will be used for missing data.

Popup HTML Generation

Introduced format_value_buy to handle value formatting based on data types.
Modified buy_popup_html to use format_value_buy for more consistent value representation.
Updated the popup HTML to include more contextual links and improved layout.

Bug Fixes

Fixed a bug in isinstance() usage in format_value_buy.
Addressed issues with formatting floats and integers in popups.