search

perfectsense / gyro-aws-provider

AWS Provider for Gyro cloud automation tool.
https://gyro.dev/providers/aws/
Apache License 2.0
8 stars 1 forks source link

Unable to configure Kinesis Firehose ARN for WAF v2 logging configuration #559

Closed ssnyder-sme closed 2 years ago

ssnyder-sme commented 2 years ago

According to the WAF v2 docs (https://gyro.dev/providers/aws/waf-v2/wafv2-web-acl.html) we should be able to set the WAF logging configuration in the gyro definition, but I'm unable to successfully set the ARN for a Kinesis Firehose.

It looks to be defined as a set, but I've tried to specify the Kinesis Firehose ARN as a list and as a single string.

Also is the error message a typo? Should be "At least one of" instead of "Atleast one off"

Example config: Screen Shot 2022-02-23 at 5 14 59 PM

Errors when running gyro up

aws::wafv2-web-acl web-acl → logging-configuration : Atleast one off 'redacted-field' or 'log-destination-configs' needs to be set.

ssnyder-sme commented 2 years ago

Looks like a code fix was merged in. Will there be a release created to include the fix?

beetlebugorg commented 2 years ago

We're testing now and we'll do a release shortly.

ssnyder-sme commented 2 years ago

Thanks!

deepanjan90 commented 2 years ago

gyro-aws-provider release 1.4.7 is now ready

Release notes can be found here : https://github.com/perfectsense/gyro-aws-provider/releases/tag/release%2F1.4.7

ssnyder-sme commented 2 years ago

It's working in v1.4.7. Thank you!