Allow DB Instance to be edited

perfectsense / gyro-aws-provider

AWS Provider for Gyro cloud automation tool.

https://gyro.dev/providers/aws/

Apache License 2.0

8 stars 1 forks source link

Allow DB Instance to be edited #661

Closed Russsnizza closed 3 weeks ago

Russsnizza commented 1 month ago

Fixes: https://github.com/perfectsense/gyro-aws-provider/issues/668

Description

This pull request adds the @Updatable annotation to the getPubliclyAccessible method. This update will allow the publiclyAccessible property to be updated after the initial object creation.

Changes

Added @Updatable annotation to the getPubliclyAccessible method.

harjain99 commented 1 month ago

The change looks good, but I believe the Issue also mentions an updatable field in dbCluster. Can we verify if that is indeed editable?

Russsnizza commented 1 month ago

The change looks good, but I believe the Issue also mentions an updatable field in dbCluster. Can we verify if that is indeed editable?

Sorted AZs should fix when DB cluster is not updated I think. I am not sure if we should enable updating getEngineVersion. It looks like we can update it in the console, but it didn't work with gyro up for me yet.

Russsnizza commented 1 month ago

Also, I don't think we can just update the DB-instance engine in the console .

Screen Shot 2024-09-26 at 14 48 44 PM