perforce / P4VS

[Officially Supported] VisualStudio plugin for HelixCore
Other
15 stars 6 forks source link

Settings fail to load when P4 Username contains '\' #13

Open razaraz opened 1 year ago

razaraz commented 1 year ago

The P4 users for our server use the AD names DomainName\ UserName. I never had settings persistence on P4V, and investigating this today, I found the culprit:

In LocalSettings.ini, there is an XML Node that is named: ActiveChangelist[Server][User][Workspace]. This node causes settings loading to throw an XmlException with the message:

The '\' character, hexadecimal value 0x5C, cannot be included in a name. Line 170, position 48.

This then prevents settings from being loaded, and a fresh empty settings file saved on top of it.