search

perforce / sonar-scm-perforce

SonarQube Perforce plugin
6 stars 23 forks source link

Use p4 filelog and p4 annotate first, then get changelist #10

Closed tyrel closed 8 years ago

tyrel commented 8 years ago

This optimizes the Perforce annotation process to be both as fast and as complete as possible. It first runs p4 annotate and p4 filelog to get the information. If, for some reason, information is missing from filelog then we'll use p4 change to look it up. In case that also fails, we'll fail gracefully by using the epoch time and "unknown" for the user.

henryju commented 8 years ago

I have no way to test but LGTM.

henryju commented 8 years ago

@mjdetullio Can you confirm this change works fine also for you? If everything is ok I'll release a 1.3.1. I guess we'll have to wait for a while before being able to use the -u option.

mjdetullio commented 8 years ago

Yes, please give me an opportunity to test. I hope to have some time this week. It looks OK at first sight.

mjdetullio commented 8 years ago

Took me forever to get to it but it seems like it's working fine on one 300k LOC project and one 1.5M LOC project so I deployed to production

tyrel commented 8 years ago

Good to hear!

By the way, my company is going to be moving from Perforce to Git over the next 12 months, so I probably won't be able to provide much more assistance here for much longer, unfortunately.