search

perforce / sonar-scm-perforce

SonarQube Perforce plugin
6 stars 23 forks source link

Blame result on branched file is incorrect. #3

Closed halfwhite closed 9 years ago

halfwhite commented 9 years ago

When a file is branched, its revision id restarts from 1. So, 2 different lines can have the same revision id even though they have been submitted in 2 different changelists. Since the perforce blame command is based on the revision id of each line, the result might be incorrect. The solution I'm proposing is to use changelist number to identify the author of a line. Also the meanings of revision id in SVN or commit id in GIT (they are used in blame result of corresponding plugins) are more similar to perforce changelist number that to revision id. So with this change blame information contains changelist number instead of revision id.

henryju commented 9 years ago

Again may thanks. I have created ticket http://jira.codehaus.org/browse/SONARSCPER-3 and applied your PR.

halfwhite commented 9 years ago

Hi, BTW, I tried to create a ticket but could not specify the project "SonarQube SCM Perforce". I see many other projects but not the one I need. Do you know what might be a reason of that?

Regards, Igor

On 30 January 2015 at 13:26, Julien HENRY notifications@github.com wrote:

Again may thanks. I have created ticket http://jira.codehaus.org/browse/SONARSCPER-3 and applied your PR.

— Reply to this email directly or view it on GitHub.

henryju commented 9 years ago

We are not accepting "wild" creation of JIRA ticket. The process is to first discuss the issue on SQ dev mailing list. This is to avoid too many "duplicate/inapropriate" JIRA ticket creation. But submitting good PR is also a way to get our attention :)