performancecopilot / grafana-pcp

Performance Co-Pilot Grafana Plugin
https://grafana-pcp.readthedocs.io
Apache License 2.0
111 stars 18 forks source link

grafana-pcp 5.0.0 not working with grafana 9.1.3 #165

Closed ke3vin closed 1 year ago

ke3vin commented 1 year ago

Data source: PCP Redis

Describe the bug I've just installed grafana-pcp 5.0.0 from github into an existing, grafana 9.1.3 server. I guess the first question is whether or not this combination is even expected to work. When setting up the PCP Redis datasource, I've left all of the default settings (all auth turned off, and URL as http://localhost:44322) Clicking 'Save & Test' fails with the error:

network error: Get "/series/ping": unsupported protocol scheme ""

If I try to use the 'Explore' button on the datasource page, as soon as I start typing in the search box I get the error

network error: Get "/series/metrics?match=k%2A": unsupported protocol scheme ""

If I use curl on the server to those URLs, I get valid responses back:

# curl localhost:44322/series/ping
{"success":true}

Versions (please complete the following information):

andreasgerstmayr commented 1 year ago

Per default the URL is empty, the grey text is only a suggestion, not a default value. If you enter http://localhost:44322 it should work.

I'll add validation to check for empty URLs, the current error message is definitely not helpful.

ke3vin commented 1 year ago

Wow I feel like an idiot for not noticing that, but as you said, the error messages didn't help much. Thanks for the help!