search

performancecopilot / speed

A Go implementation of the PCP instrumentation API
MIT License
37 stars 6 forks source link

code review: add case int; TypeSwitchGuard short variable declaration #14

Closed peterGo closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.5%) to 64.836% when pulling f14ec12ece9c5ff09643e7efdfd9dc853651cdd4 on peterGo:metrics-WriteVal into 15eb629976ce2d6916ec657c37c0f51aa90bdf12 on performancecopilot:master.

suyash commented 8 years ago

A couple of things

  1. We will never write int, the resolveInt function takes care of resolving int to one of int32, int64, uint32 and uint64, and that is kind of what we are going for, it removes any ambiguity related to the type, if you specified the MetricType as Uint32Type, the only value you can get is uint32, not uint or int. The rest is upto the user.
  2. Please always submit pull requests after rebasing with the latest upstream. The commit Merge pull request #1 from performancecopilot/master looks odd in the git history. Just add an upstream remote as the https address to this repository, pull to master and rebase your branch to it before submitting the PR.

But thanks for the general idea, looks cool :+1: