search

performancecopilot / speed

A Go implementation of the PCP instrumentation API
MIT License
37 stars 6 forks source link

Fix semantic import versioning #63

Closed sagikazarmark closed 3 years ago

sagikazarmark commented 3 years ago

Unfortunately, I completely missed the fact that this library is already past v1 and that the module name is not properly versioned (according to Go module practices). That causes some issues when trying to import this module.

This PR adds a v4 version to the module name (unfortunately, that's the only way to fix this problem) that would require tagging a v4.0.0 version.

The alternative is for projects to import commits directly, so all is not lost.

Read more here: https://blog.golang.org/v2-go-modules

natoscott commented 3 years ago

@ sagikazarmark thanks! - merged, tagged a v4.0.0, and sent you an invite to write directly to this repo if you'd like - get's me out of your way :)

sagikazarmark commented 3 years ago

@natoscott cool, thanks!