search

performant-software / textlab

A collaborative space for creating and publishing digital critical editions.
http://www.textlab.org
GNU General Public License v3.0
13 stars 4 forks source link

CSS compilation error #168

Closed SteveMarvin closed 7 years ago

SteveMarvin commented 7 years ago

When attempting to log in to app.textlab.org, the following error is produced. A refresh seems to clear it up.

screen shot 2017-09-21 at 10 34 51 am

NickLaiacona commented 7 years ago

I think this is likely do to an interaction between the JVM, JRuby, Rails, and the Heroku server environment.

feralresearch commented 7 years ago

@NickLaiacona I'm still working on this, but I haven't been able to generate the error.

It does seem related to the asset pipeline because of the "error compiling CSS", this is odd because this runs cleanly (except for the warnings). Local assets:recompile also works fine. I'm debating the merits of resolving the warnings (updating the gems I guess, may try that locally but not helpful if I can't generate the error): heroku run rake assets:precompile --trace

Question: can we try precompiling the assets instead of generating them at runtime? (IE any reason we need them to dynamically compile?) That doesn't really solve the issue but it should avoid it.

Related: Any other info on how to generate this error? Is it only on login? Have you seen it on dev or local or only on production?

NickLaiacona commented 7 years ago

It should be only compiling them once, since the RAILS_ENV variable is set to "production". Maybe try pushing a trivial change to staging, see if that can provoke it into this state? If so.. perhaps we just run heroku run rake assets:precompile immediately after pushing the new code as part of our deployment procedure.

On Thu, Nov 2, 2017 at 12:06 PM, Andrew Sempere notifications@github.com wrote:

@NickLaiacona https://github.com/nicklaiacona I'm still working on this, but I haven't been able to generate the error.

It does seem related to the asset pipeline because of the "error compiling CSS", this is odd because this runs cleanly (except for the warnings): heroku run rake assets:precompile --trace

Question: can we try precompiling the assets instead of generating them at runtime? (IE any reason we need them to dynamically compile?)

Related: Any other info on how to generate this error? Is it only on login? Have you seen it on dev or local or only on production?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/performant-software/textlab/issues/168#issuecomment-341471817, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAsr3bR1828thWP7v8U4nN1fU7TwJWnks5syeiYgaJpZM4Pfa84 .

feralresearch commented 7 years ago

I don't see the error if I run it local or production, even if I run a 'clean' first...

but in any case (I think) that's what I"m suggesting, we run precompile manually instead of making the assets generate dynamically. We only need to do this if we change the CSS - we check the /public/assets folder into the repo and heroku shouldn't try and build them again. Still doesn't pinpoint what's wrong but it's a workaround to spending more time hunting down the error.

feralresearch commented 7 years ago

Can reproduce by: pushing to PR instance, restarting the instance.

Things that don't seem to work: Precompiling the assets (grrr)

Suspicion: there's a sass version issue. there are various attempts at things in the "as-sidebar" branch