search

performant-software / textlab

A collaborative space for creating and publishing digital critical editions.
http://www.textlab.org
GNU General Public License v3.0
13 stars 4 forks source link

Subst tag not rendering original text in popover #247

Open NickLaiacona opened 3 years ago

NickLaiacona commented 3 years ago

An example of this is on leaf 51 of Billy Budd, in this snippet of code:

<subst facs="#img_51-0044" >
<del rend=" _ink1" hand="#HM" change="StBb" facs="#img_51-0044" >capstan</del>
<add place="inline" rend="no-caret _ink1" hand="#HM" change="StBb" facs="#img_51-0044" >capstain</add>
</subst>

It says, Melville wrote "capstan", then changed it later to "capstain".

TextLab should render the word "capstain" and if the user mouses over the word, a popup should appear showing the original "capstan". Presently, "capstain" is rendered as an <add> and no mention of "capstan".

dleadbetter commented 3 years ago

@NickLaiacona - It looks like a del element followed by an add element is sometimes rendered as a strikethrough decoration on the del element, followed by the add element. Is there a TEI rule for when the del element should be rendered and when it should be hidden and displayed on the popup?

NickLaiacona commented 3 years ago

In a normal add or del, we aren't reporting that one was subbed for the other. We're just saying this was deleted or that was added. When the del and add pair are contained in a subst element, it means that one phrase was substituted for the other phrase. So initially the deleted text was written and then it was substituted with the added text. The client wants to represent this by showing the added text inline and then placing the deleted text in a popover.