search

performant-software / textlab

A collaborative space for creating and publishing digital critical editions.
http://www.textlab.org
GNU General Public License v3.0
13 stars 4 forks source link

TL #247 - Substitution popover #252

Closed dleadbetter closed 3 years ago

dleadbetter commented 3 years ago

This pull request fixes a bug where the subst tag was not rendering the original text. This should have been present in a popover, however there was a bug with the way the popover location was being calculated.

textlab_hover_delete

dleadbetter commented 3 years ago

It looks like the TEI markup on staging varies from what is in production.

Production

<subst facs="#img_51-0044" >
  <del rend=" _ink1" hand="#HM" change="StBb" facs="#img_51-0044" >capstan</del>
  <add place="inline" rend="no-caret _ink1" hand="#HM" change="StBb" facs="#img_51-0044" >capstain</add>
</subst>

Staging

<subst facs="#img_51-0025">
  <del facs="#img_51-0025" rend="overwritten" type="superimposed" hand="#ink1">n</del>
  <add facs="#img_51-0025" rend="superimposed" type="superimposed" hand="#ink1r" change="#StDa">n</add>
</subst>

Another example of this change on staging would be in Leaf 71:

<subst facs="#img_71-0028">
  <del facs="#img_71-0028" rend="overwritten _ink1" type="superimposed" hand="#HM">air</del>
  <add facs="#img_71-0028" rend="superimposed _ink1" type="superimposed" hand="#ESM" change="#StBb">an</add>
</subst>
NickLaiacona commented 3 years ago

Ah, OK. Looks good then. 👍