search

performant-software / textlab

A collaborative space for creating and publishing digital critical editions.
http://www.textlab.org
GNU General Public License v3.0
13 stars 4 forks source link

Select a tag from the tag dropdown list, and Textlab exits to the landing page #255

Open jamiefolsom opened 3 years ago

jamiefolsom commented 3 years ago

The problem lies with the embedding of the TEI XML tags in the editor. The only tag that seems to work in an expected way is the linebreak (</lb>). Other tags when chosen from a zoned box aren’t embedded in the transcription. If tags are chosen from the tag dropdown list, the program exits to the landing page listing the projects available.

dleadbetter commented 3 years ago

From the Javascript console:

Uncaught TypeError: Cannot read properties of undefined (reading 'models')
    at child.render (attribute-modal-dialog.self-67c11572fec6b4b75ded156f6924842dca5d406b871e9a833d1fae2d1c30bbf5.js?body=1:123)
    at child.activateTagDialog (xml-editor.self-9a1ce1275b67c365ea65fdbc5ad33dda40fad0a8bc3d45bea6c464bdb5a64bd5.js?body=1:85)
    at child.onClickTagMenuItem (xml-editor.self-9a1ce1275b67c365ea65fdbc5ad33dda40fad0a8bc3d45bea6c464bdb5a64bd5.js?body=1:101)
    at HTMLDivElement.dispatch (jquery.self-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js?body=1:4738)
    at HTMLDivElement.elemData.handle (jquery.self-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js?body=1:4550)

Looks to be an issue in xml-editor.js or attribute-modal-dialog.js. Estimated time to fix: 6 hours

SteveMarvin commented 2 years ago

certain tags will still crash it, such as:

subst restore del

SteveMarvin commented 2 years ago

Looks like the tags that triggered modals were at fault, seems all good now. 👍