[Design] Separate "backgrounds" folder for each theme

marwin89 commented 9 months ago

Suggestion

It would be cool if every theme has their own "backgrounds"-subfolder for songqueqe-menu like:

performous/themes/performous+/backgrounds/

Current State	Suggested State
Can't style the backgrounds of songqueqe-menu	style the backgrounds of songqueqe-menu, backgrounds don't get mixed up with default background-svgs
There is one "backgrounds"-folder for all themes	every theme has their own "backgrounds"-subfolder
backgrounds-folder is used for songqueqe-menu backgrounds	songqueqe-menu backgrounds only refers to the backgrounds-subfolder of the selected theme
performous/backgrounds	removed
performous/themes/performous+/backgrounds/ is not used	performous/themes/performous+/backgrounds/ is used for songqueqe-menu backgrounds
performous/themes/default/backgrounds/ is not used	performous/themes/default/backgrounds/ is used for songqueqe-menu backgrounds

Use case

As a theme designer I want to select the backgrounds that fit to the style of my theme.
I don't want them to be mixed up with the default backgrounds or backgrounds of other themes. Cause the backgrounds of default or backgrounds of other new themes have a complete different style than my theme.
I guess other theme designers need that as well.

Extra info/examples/attachments

Current state: all backgrounds get mixed in song-queqe-menu performous-backgrounds-folder Suggestet state: only the backgrounds of the selected theme will be shown in song-queqe-menu background performous-theme-subfolder-backgrounds

twollgam commented 9 months ago

@marwin89 thanks for the issue. Can you explain the difference between the current and the suggested state. Is it only for sorting the images into folders or can't you replace default images with your own. (What is really necessary for themes ;-) )

It would also help, if you extend the folder examples with real file names. I have looked into the current folders and left confused. ;-)

marwin89 commented 9 months ago

@twollgam thanks for your feedback. The infos are updated now. I hope I've explained it well this time. 👋

twollgam commented 9 months ago

@marwin89 good description now 👍 Many thanks

twollgam commented 5 months ago

The issue is related to pr #933.

performous / performous