search

performous / web

Performous website
https://performous.org
4 stars 4 forks source link

Modernize (thanks ChatGPT), remove jQuery, add README. #18

Closed Tronic closed 1 year ago

Tronic commented 1 year ago

Avoid security warnings about jQuery.

Baklap4 commented 1 year ago

will take a look somewhere this week, build is failing at this moment not sure why though

Tronic commented 1 year ago

The CI lacks SSH keys to Github so that it could clone (and presumably also push to after update) gh-pages. This happens in local-deploy.sh:

git clone --depth=50 --branch=gh-pages git@github.com:performous/web.git
Tronic commented 1 year ago

The showcase image scroller should really be done with CSS animation, but ChatGPT didn't provide correct code for that change, so I left the JS implementation (but at least it uses requestAnimationFrame to run smoother).

Tronic commented 1 year ago

Also this way of updating keeps old files that previously existed in gh-pages (such as the deleted jQuery files that GitHub keeps sending me warnings of). I suggest you put all static files in htdocs-binary, remove that git clone from the script such that no old files are placed in the generated web folder, and change your CI so that it deleted all old files and then adds the files from the web folder (I think git will still track changes as modifications if the same file was deleted and added in the same commit).

Tronic commented 1 year ago

Still getting those jQuery security alerts. Could you get this deployed please?

Tronic commented 1 year ago

@Baklap4 Hello?

ooshlablu commented 1 year ago

@Tronic I tried to see what the issue with Semaphore was, but it never loads the log or anything when I look at it. I do have a task to convert this over to GitHub Actions at some point. I did start a new job a few weeks ago, so I'm pretty busy at the moment, but I'm hoping I will get to it soon. If this PR isn't merged by that point then I'll ping you again, and we can rebase and get it moving.

Baklap4 commented 1 year ago

@Tronic i've rebased this on to current master. This will make sure GH-Actions run and i can try it out locally. If all is well it'll get merged right away. Thanks for updating sources!